Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

External projects don't resolve sources properly #109

Closed
thii opened this issue Oct 25, 2019 · 3 comments · Fixed by #229
Closed

External projects don't resolve sources properly #109

thii opened this issue Oct 25, 2019 · 3 comments · Fixed by #229

Comments

@thii
Copy link
Member

thii commented Oct 25, 2019

External project sources get set to the path tulsi-workspace/external/MyExternalWorkspace while tulsi-workspace doesn't exist (it doesn't get generated anymore as of the version 0.4.276307939.20191023 (the latest when I'm writing this).

94C190809CD0FD5100000000 /* @Reachability */ = {
  isa = PBXGroup;
  children = (
    00C7263701CA77DC00000002 /* BUILD.bazel */,
    00C726379A5E4D8600000000 /* Reachability.h */,
    00C7263733DBC80E00000000 /* Reachability.m */,
  );
  name = "@Reachability";
  path = "tulsi-workspace/external/Reachability";
  sourceTree = "<group>";
};
@DavidGoldman
Copy link
Contributor

I would expect it to exist after Bazel creates symlinks (e.g. after building), where do you see the MyExternalWorkspace in the Bazel execution root?

@thii
Copy link
Member Author

thii commented Dec 27, 2019

There is a tulsi-workspace symlink at MyProject.xcodeproj/.tulsi/tulsi-workspace but not at the project root. MyExternalWorkspace is at MyProject.xcodeproj/.tulsi/tulsi-workspace/external/MyExternalWorkspace.

The current workaround is to manually create a symlink tulsi-workspace -> MyProject.xcodeproj/.tulsi/tulsi-workspace.

@DavidGoldman
Copy link
Contributor

This is likely an oversight in 7d73230, we should make sure all references to the tulsi-workspace are via the proper symlink in the xcodeproj.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants