Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cross-repository references broken in Bazel 2.0 #43

Closed
alexeagle opened this issue Dec 17, 2019 · 2 comments · Fixed by #44
Closed

cross-repository references broken in Bazel 2.0 #43

alexeagle opened this issue Dec 17, 2019 · 2 comments · Fixed by #44

Comments

@alexeagle
Copy link
Contributor

Noted here:

bazelbuild/bazel#10131 (comment)

the pattern of handling cross-repository references which was introduced for rules_rust (and I then borrowed in rules_nodejs) is broken by the next upcoming Bazel release
@alexeagle alexeagle changed the title Broken in Bazel 2.0 cross-repository references broken in Bazel 2.0 Dec 17, 2019
@alexeagle
Copy link
Contributor Author

Ping - now that Bazel 2.0 is shipped, our CI went red on bazelci

@c-parsons c-parsons mentioned this issue Dec 19, 2019
Merged
@c-parsons
Copy link
Collaborator

I believe this was caused by the Bazel flag flip --incompatible_remap_main_repo in 2.0. #44 should fix this regardless of that flag value.

@alexeagle alexeagle mentioned this issue Dec 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ctx.workspace_name instead of ctx.label_workspace bazelbuild/stardoc
2 participants
@alexeagle @c-parsons