Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RunEnvironmentInfo instead of testing.TestEnvironment #901

Open
rickeylev opened this issue Nov 28, 2022 · 2 comments
Open

Use RunEnvironmentInfo instead of testing.TestEnvironment #901

rickeylev opened this issue Nov 28, 2022 · 2 comments
Assignees
@rickeylev
Labels
cleanup Tech debt, resolving it improves our own velocity help wanted type: toolchain Related to the toolchains provided by rules_python

Comments

@rickeylev
Copy link
Collaborator

Code health

Relevant Rules

The upcoming multi-toolchain supporting rules. (see #846)

Description

The multi-toolchain supporting rules forward on testing.TestEnvironment, but that name is deprecated, and is replaced by RunEnvironmentInfo.

That symbol is only present in Bazel 5.3+, though, so until support for that is dropped, we have to continue using the old name.
This was referenced Nov 28, 2022
Merged
Merged
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label May 27, 2023
@rickeylev rickeylev self-assigned this May 28, 2023
@rickeylev rickeylev removed the Can Close? Will close in 30 days if there is no new activity label May 28, 2023
@aignas aignas added cleanup Tech debt, resolving it improves our own velocity type: toolchain Related to the toolchains provided by rules_python labels Jan 22, 2024
@aignas
Copy link
Collaborator

aignas commented Jan 22, 2024

Maybe we could use bazel-features ruleset here. Anybody wishing to contribute to rules_python could pick this up as this may be a good first issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickeylev rickeylev

Labels
cleanup Tech debt, resolving it improves our own velocity help wanted type: toolchain Related to the toolchains provided by rules_python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aignas @rickeylev