Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue seems to have been filed, but info doesn't show any breaking information #893

Closed
thomasvl opened this issue Dec 19, 2019 · 4 comments

Comments

@thomasvl
Copy link
Member

We had bazelbuild/rules_apple#672 filed, but looking at the referenced log, it shows the whole step as green, does list the flag under Migration is needed for the following flags:, but in the output, there doesn't appear to be anything to say what actually failed to let one see what the problem was; attached is the screen show of the UI I'm seeing.

Screen Shot 2019-12-19 at 10 05 38 AM

@alexeagle
Copy link
Contributor

Same for rules_nodejs, I suspect these bot-filed issues were for 1.2 and no longer apply?

@jayconrod
Copy link

Same for rules_go. I found the test results hard to read. Everything's green, but it you click through the disclosure triangles for some of the steps with flags, there are errors. Only some of the steps though, and only on some platforms. It's hard to find what went wrong.

The actual issues aren't very helpful either. They should link to the tracking issue for each incompatible flag with migration instructions. If there's any person managing these flags they should be cc'd. Not obvious who I would ask for help with some of the more complicated flags. The issue markdown isn't correct (link addresses are HTML tags instead of URLs).

@fweikert
Copy link
Member

There were several bugs related to the title and content of issues, all of which I have fixed. You should see new issues soon.

For example, the version number 1.2.1 was wrong (since we only flip flags in major releases).
@thomasvl Unfortunately Buildkite truncates large logs, so you have to click on "Download" in the top right corner to see the error.

@fweikert
Copy link
Member

There will also be fewer issues since we released 2.0 in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants