Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Running the bazel tests with a custom configuration #562

Open
iirina opened this issue Mar 11, 2019 · 2 comments
Open

FR: Running the bazel tests with a custom configuration #562

iirina opened this issue Mar 11, 2019 · 2 comments
Assignees
Labels

Comments

@iirina
Copy link
Contributor

iirina commented Mar 11, 2019

The Java tools have been recently moved out of the bazel binary (see bazelbuild/bazel#6316) and are now released separately. However the Java tools need to maintain the same level of testing coverage as before. One idea is to introduce a new flag in Bazel that points to a Java tools archive and have a presubmit pipeline running all the bazel tests with the flag pointing to the Java tools archive built at head. Other ideas of keeping the same testing coverage are welcome.

cc: @fweikert

@fweikert fweikert added the FR label Mar 11, 2019
@philwo
Copy link
Member

philwo commented May 28, 2019

@iirina How could we point Bazel to another Java tools archive, if not with a flag? Modify a WORKSPACE file somehow, maybe?

I'm sure we can set this up, but I don't know what exactly you need and on which pipeline :)

@philwo philwo self-assigned this May 28, 2019
@philwo philwo added the P2 label May 28, 2019
@iirina
Copy link
Contributor Author

iirina commented May 29, 2019

A way to do this is to add the http_archive in the WORKSPACE file and then specify --java_toolchain=@java_tools//:toolchain as build flag (similar to how ubuntu1804_javabase9 and ubuntu1804_javabase10 are set up).

However, given that we have different java_tools releases for java 9, 10, 11 and soon 12, I'm not sure it scales to add this overhead on our CI. Maybe it's worth doing so on postsubmit. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants