Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel 0.23.0rc3: git_repository not working with https URL #7522

Closed
or-shachar opened this issue Feb 24, 2019 · 4 comments
Closed

bazel 0.23.0rc3: git_repository not working with https URL #7522

or-shachar opened this issue Feb 24, 2019 · 4 comments
Labels
more data needed team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged

Comments

@or-shachar
Copy link
Contributor

or-shachar commented Feb 24, 2019

Just tried Bazel 0.23.0rc3 ( #6495 ) on Linux with git 2.20.1.

Seems like there was a change to git_repository behavior...
Previously this would work for us:

git_repository(
    name = "io_bazel_rules_appengine",
    remote = "https://github.com/bazelbuild/rules_appengine",
    remote = "git@github.com:bazelbuild/rules_appengine.git",
    commit = "f6a099e3c07672438768183578192d56d46fef80",
)

Now it will result in error:

17:55:00  + git clone https://github.com/bazelbuild/rules_appengine /home/builduser/.cache/bazel/_bazel_builduser/d95f300509f1e228190b211abeba17c4/external/io_bazel_rules_appengine
17:55:00  Cloning into '/home/builduser/.cache/bazel/_bazel_builduser/d95f300509f1e228190b211abeba17c4/external/io_bazel_rules_appengine'...
17:55:00  warning: templates not found in /tmp/git/share/git-core/templates
17:55:00  fatal: unable to find remote helper for 'https'

Had to change the git URL to git@github.com:bazelbuild/rules_appengine.git and then it worked.

Is it a known declared change?

@aehlig
Copy link
Contributor

aehlig commented Feb 25, 2019

Is it a known declared change?

None that I'm aware of. Also, the definition of the git_repository rule hasn't changed since the last release and commands executed by a repository rule are not sandboxed.

Also note that the error message was generated by git. Does git clone https://github.com/bazelbuild/rules_appengine work when called directly (i.e., outside bazel)?

@gertvdijk
Copy link
Contributor

@or-shachar
That git error message looks completely unrelated to Bazel indeed and points to a problem with your local git installation (google it).

@irengrig
Copy link
Contributor

irengrig commented Mar 1, 2019

@or-shachar, have you been able to resolve the problem? Is that appears to be the problem on the Git side?
Thank you.

@jin jin added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged labels Mar 25, 2019
@or-shachar
Copy link
Contributor Author

@irengrig I resolved by setting the right git url... Not sure why it worked beforehand with the wrong format. But I guess it's for the best that it failed.

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more data needed team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged
Projects
None yet
Development

No branches or pull requests

6 participants