Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermetic Python 3 test is missing #3567

Closed
abergmeier-dsfishlabs opened this issue Aug 16, 2017 · 3 comments
Closed

Hermetic Python 3 test is missing #3567

abergmeier-dsfishlabs opened this issue Aug 16, 2017 · 3 comments
Assignees
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Python Native rules for Python type: process

Comments

@abergmeier-dsfishlabs
Copy link
Contributor

Description of the problem / feature request / question:

While Python 2 is getting tested in https://github.com/bazelbuild/bazel/blob/master/src/test/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyRuntimeTest.java, there is no such test for Python 3.
Since Bazel is notorious for breaking Python 3 - please ensure that this gets tested.

@iirina iirina added category: rules > python P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Aug 16, 2017
@abergmeier-dsfishlabs
Copy link
Contributor Author

Here is what this leads to: #3568

@brandjon brandjon assigned brandjon and unassigned lberki Oct 17, 2018
@brandjon
Copy link
Member

I'm not exactly clear on what test coverage this issue is requesting, or that it's specifically a Py 2/3 issue as opposed to just a py_runtime issue.

@brandjon
Copy link
Member

Closing this because the problem's unclear.

For py_runtime analysis-time tests we now have PyRuntimeConfiguredTargetTest.

For end-to-end tests we have some attempt to launch both a Python 2 and Python 3 runtime, though the coverage could stand to be improved (#6868). This will wait until at least after the toolchain work is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Python Native rules for Python type: process
Projects
None yet
Development

No branches or pull requests

4 participants