Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub codeowners group not working #15101

Closed
keith opened this issue Mar 22, 2022 · 7 comments
Closed

GitHub codeowners group not working #15101

keith opened this issue Mar 22, 2022 · 7 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process

Comments

@keith
Copy link
Member

keith commented Mar 22, 2022

It looks like the rules apple team who is supposed to be an owner of some of the objc logic is not working correctly

#14844 (comment)

You can see github reporting errors on https://github.com/bazelbuild/bazel/pull/14614/files

I believe it's because the team doesn't include the bazel repo https://github.com/orgs/bazelbuild/teams/rules_apple-team/repositories, and I wonder what level of access the team would have to have for this to work, if just "read" would be enough or not.

@aiuto can you debug? I assume you need admin access to fix anything here

@sgowroji sgowroji added untriaged team-Bazel General Bazel product/strategy issues labels Mar 23, 2022
@aiuto aiuto self-assigned this Mar 31, 2022
@aiuto
Copy link
Contributor

aiuto commented Mar 31, 2022

I'm about to do an audit and clean up of lots of group memberships. I'll check as part of that.

@aiuto aiuto added P2 We'll consider working on this in future. (Assignee optional) type: process and removed untriaged labels Mar 31, 2022
@keith
Copy link
Member Author

keith commented Mar 8, 2023

@aiuto bump

@aiuto
Copy link
Contributor

aiuto commented Mar 14, 2023

Sorry. I did not get a chance to look at this. But it really does belong to @meteorcloudy's team, so passing it to him.

@aiuto aiuto removed their assignment Mar 14, 2023
@sgowroji sgowroji added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website and removed team-Bazel General Bazel product/strategy issues labels Mar 14, 2023
@meteorcloudy
Copy link
Member

@keith Added read access to Bazel repo for rules apple team, let me know if it works.

@brentleyjones
Copy link
Contributor

I'm thinking write access is what will be needed:

Unknown owner on line 34: make sure the team @bazelbuild/rules_apple-team exists, is publicly visible, and has write access to the repository.

@meteorcloudy
Copy link
Member

OK, this should be fixed now.

@keith
Copy link
Member Author

keith commented Mar 15, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process
Projects
None yet
Development

No branches or pull requests

5 participants