From 7b4acfe5bf510a887c7efa021f57b8f7bf5a0713 Mon Sep 17 00:00:00 2001 From: Googler Date: Wed, 25 Jan 2023 11:48:07 -0800 Subject: [PATCH] Flip --incompatible_objc_linking_info_migration to true See https://github.com/bazelbuild/bazel/issues/16939. This flips the default behavior so that builtin Objective C rules will get their linking info from CcInfo instead of ObjcProvider. We will start cleaning up apple/swift starlark rules to stop generating linking info in ObjcProvider, so it makes sense to flip the default for this flag before those changes land in open source. RELNOTES[inc]: builtin objc rules will get their linking info from CcInfo, not ObjcProvider PiperOrigin-RevId: 504621116 Change-Id: I78ab2d3aca85dc0c7ef754dc8240ffa6a8f66ab9 --- .../devtools/build/lib/rules/objc/ObjcCommandLineOptions.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommandLineOptions.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommandLineOptions.java index d49569b4b49e8d..1b386be9df37a7 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommandLineOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommandLineOptions.java @@ -171,7 +171,7 @@ public class ObjcCommandLineOptions extends FragmentOptions { @Option( name = "incompatible_objc_linking_info_migration", - defaultValue = "false", + defaultValue = "true", documentationCategory = OptionDocumentationCategory.TOOLCHAIN, effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS, OptionEffectTag.CHANGES_INPUTS}, metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},