From 7222cabcd1d98a1e3f2f3c7eee4f1816c372605a Mon Sep 17 00:00:00 2001 From: emilyguo Date: Tue, 19 Apr 2022 13:32:09 -0700 Subject: [PATCH] Change to a lower-noise reporting method. It can avoid to keep sending Third eye reports, but still get error message to help further investigation. PiperOrigin-RevId: 442897019 --- .../google/devtools/build/lib/skyframe/AspectFunction.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java index 006c6390bd297b..bb7c9d74a4d554 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java @@ -248,9 +248,8 @@ public SkyValue compute(SkyKey skyKey, Environment env) for (AspectKey aspectKey : orderedKeys) { AspectValue aspectValue = (AspectValue) aspectValues.get(aspectKey); if (aspectValue == null) { - BugReport.sendBugReport( - new IllegalStateException( - "aspectValue " + aspectKey + " was missing, this should never happen")); + BugReport.logUnexpected( + "aspectValue for: '%s' was missing, this should never happen", aspectKey); return null; } topologicalAspectPathBuilder.add(aspectValue.getAspect());