You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
The static members in WorkspaceDriver should be moved to an Environment class that would be shared to different instances of WorkspaceDriver (through a constructor, e.g. WorkspaceDriver(Environment environment, String bazelVersion)).
A default, shared Environment should be provided by a TestRule implementation of WorkspaceDriver (WorkspaceDriverTestRule) which would set up everything for a JUnit test. I do not advocate here for putting the Environment in a ClassRule, I was more thinking about a singleton.
BazelBaseTestCase should be removed.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I think that in terms of ergonomics:
The static members in WorkspaceDriver should be moved to an Environment class that would be shared to different instances of WorkspaceDriver (through a constructor, e.g.
WorkspaceDriver(Environment environment, String bazelVersion)
).A default, shared Environment should be provided by a TestRule implementation of WorkspaceDriver (WorkspaceDriverTestRule) which would set up everything for a JUnit test. I do not advocate here for putting the Environment in a ClassRule, I was more thinking about a singleton.
BazelBaseTestCase should be removed.
The text was updated successfully, but these errors were encountered: