Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

[Refactoring] Remove static members in WorkspaceDriver and provide a @TestRule #74

Open
hchauvin opened this issue Apr 29, 2018 · 0 comments

Comments

@hchauvin
Copy link
Contributor

hchauvin commented Apr 29, 2018

I think that in terms of ergonomics:

  1. The static members in WorkspaceDriver should be moved to an Environment class that would be shared to different instances of WorkspaceDriver (through a constructor, e.g. WorkspaceDriver(Environment environment, String bazelVersion)).

  2. A default, shared Environment should be provided by a TestRule implementation of WorkspaceDriver (WorkspaceDriverTestRule) which would set up everything for a JUnit test. I do not advocate here for putting the Environment in a ClassRule, I was more thinking about a singleton.

  3. BazelBaseTestCase should be removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant