From cfcb0bfdacc6f5223525fcc8769ec6fd2b4f1954 Mon Sep 17 00:00:00 2001 From: John Szumski <784312+jszumski@users.noreply.github.com> Date: Fri, 2 Jun 2023 17:12:08 -0400 Subject: [PATCH] Fix issue where a resource bundle's Info.plist value for CFBundleName incorrectly included the bundle extension (#728) --- rules/precompiled_apple_resource_bundle.bzl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules/precompiled_apple_resource_bundle.bzl b/rules/precompiled_apple_resource_bundle.bzl index 5f3793cbd..0ee190a01 100644 --- a/rules/precompiled_apple_resource_bundle.bzl +++ b/rules/precompiled_apple_resource_bundle.bzl @@ -121,7 +121,7 @@ def _precompiled_apple_resource_bundle_impl(ctx): control_files = [] input_files = [] output_files = [] - output_bundle_dir = ctx.actions.declare_directory(paths.join(ctx.attr.name, bundle_name + ".bundle")) + output_bundle_dir = ctx.actions.declare_directory(paths.join(ctx.attr.name, bundle_name + ctx.attr.bundle_extension)) # Need getattr since the partial_ouput struct will be empty when there are no resources. # Even so, we want to generate a resource bundle for compatibility. @@ -252,7 +252,7 @@ _precompiled_apple_resource_bundle = rule( ), bundle_extension = attr.string( mandatory = False, - default = "bundle", + default = ".bundle", doc = "The extension of the resource bundle.", ), platforms = attr.string_dict(