Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not access --action_env variables from rollup config. #1648

Closed
thesayyn opened this issue Feb 17, 2020 · 1 comment
Closed

Can not access --action_env variables from rollup config. #1648

thesayyn opened this issue Feb 17, 2020 · 1 comment
Labels
Can Close? We will close this in 30 days if there is no further activity duplicate

Comments

@thesayyn
Copy link
Collaborator

🚀 feature request

Relevant Rules

rollup_bundle. (Maybe other rules are affected as well.)

Description

As it says https://bazel.build/designs/2016/06/21/environment.html rules can access the environment variables that have been set with --action-env option if the rule executes the action with use_default_shell_env variable set to true.

Describe the solution you'd like

We should be able to access env variables to make our config files to be responsive to the environment changes.

Use case

I have needed this feature when I was trying to eliminate environmentally changed code paths by using rollup-plugin-terser and @rollup/plugin-replace.

@evahowe evahowe added duplicate Can Close? We will close this in 30 days if there is no further activity labels Jul 23, 2020
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity duplicate
Projects
None yet
Development

No branches or pull requests

2 participants