Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_proto_library: report errors for unknown imports #1529

Open
jayconrod opened this issue Jun 6, 2018 · 0 comments
Open

go_proto_library: report errors for unknown imports #1529

jayconrod opened this issue Jun 6, 2018 · 0 comments

Comments

@jayconrod
Copy link
Contributor

go_proto_library may depend on go_proto_library and go_library targets (anything that provides the GoLibrary provider). If a go_proto_library depends on a go_library built from .pb.go files that were pre-generated from some .proto file, it will not know how to map proto imports to the go_library. That information is communicated through the GoProtoImports provider, generated by the go_proto_aspect.

We should report an error (or at least a warning) whenever we're building a proto library and we don't know how to map an imported .proto to a Go import path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant