-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Next] Update rules-proto-grpc once next branch is merged #225
Comments
@aaliddell Do you have some examples of toolchains that are configured this way? E.g. how do I make a constraint conifgurable via a flag? |
And also, is it possible to use incompatible target skipping when using the approach you mentioned? E.g. in the repo there are targets that are only compatible with certain SDK versions. |
These flags will be removed when we merge the |
Hello, is this issue about updating rules-proto-grpc so that the csharp-grpc-library etc. all work on the new |
Yes, we need to update rules_proto_grpc to use the latest release because we did multiple breaking changes recently |
Closing this. These rules and rules_proto_grpc have changed significantly since it was created. |
In recent versions you've switched to using toolchains and platforms for selecting the SDK version to be used. However, using a platform to resolve a single field in the toolchain is somewhat problematic for anyone who already has an existing platform, since it necessarily won't know about the SDK version.
Why were the config_settings not applied directly as constraints on the toolchain, rather than indirectly via the platforms? e.g
bazel build //... --@io_bazel_rules_dotnet//dotnet/toolchain:sdk_version=3.1.100
along withtarget_settings
on the toolchain definitions to restrict the resolved toolchain to one that matches the SDK version config setting.The text was updated successfully, but these errors were encountered: