Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next] Update rules-proto-grpc once next branch is merged #225

Closed
aaliddell opened this issue Feb 19, 2021 · 6 comments
Closed

[Next] Update rules-proto-grpc once next branch is merged #225

aaliddell opened this issue Feb 19, 2021 · 6 comments

Comments

@aaliddell
Copy link

aaliddell commented Feb 19, 2021

In recent versions you've switched to using toolchains and platforms for selecting the SDK version to be used. However, using a platform to resolve a single field in the toolchain is somewhat problematic for anyone who already has an existing platform, since it necessarily won't know about the SDK version.

Why were the config_settings not applied directly as constraints on the toolchain, rather than indirectly via the platforms? e.g bazel build //... --@io_bazel_rules_dotnet//dotnet/toolchain:sdk_version=3.1.100 along with target_settings on the toolchain definitions to restrict the resolved toolchain to one that matches the SDK version config setting.

@aaliddell aaliddell changed the title Use of platforms vs config_settings Use of platforms vs toolchain target_settings Feb 19, 2021
@purkhusid
Copy link
Collaborator

@aaliddell Do you have some examples of toolchains that are configured this way? E.g. how do I make a constraint conifgurable via a flag?

@purkhusid
Copy link
Collaborator

purkhusid commented Apr 3, 2021

And also, is it possible to use incompatible target skipping when using the approach you mentioned? E.g. in the repo there are targets that are only compatible with certain SDK versions.

@purkhusid
Copy link
Collaborator

These flags will be removed when we merge the next branch. I'm going to change this issue to track updating rules-proto-grpc once the next branch has been merged

@purkhusid purkhusid changed the title Use of platforms vs toolchain target_settings [Next] Update rules-proto-grpc once next branch is merged Aug 5, 2022
@Place1
Copy link
Contributor

Place1 commented Feb 23, 2023

Hello, is this issue about updating rules-proto-grpc so that the csharp-grpc-library etc. all work on the new @rules_dotnet instead of io_bazel_rules_dotnet?

@purkhusid
Copy link
Collaborator

Yes, we need to update rules_proto_grpc to use the latest release because we did multiple breaking changes recently

@purkhusid
Copy link
Collaborator

Closing this. These rules and rules_proto_grpc have changed significantly since it was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants