incompatible or wrong C11 Threads return value handling

[DenisPolygalov]

Hi,
the problem is the following code:

re/src/main/main.c

Line 182 in 4dfae41

if (err) {

You assume that the success code is zero, which is not the case in FreeBSD implementation for example:
https://github.com/freebsd/freebsd-src/blob/3c9ad9398fcdf5f49114fde978b7c837b7ebbc8d/lib/libstdthreads/threads.h#L68

In the standard the value of thrd_success is unspecified:
https://en.cppreference.com/w/c/thread/thrd_errors
So I think return value of all functions related to threads.h must be explicitly compared with members of the enum

Note that the specific line of code in libre source code might be not the only one existed in all 3 projects (re/rem/baresip).
Multiple places where return values get checked might be affected.

Regards,
Denis.

[sreimers]

Thanks for report, I'm currently preparing some PRs to fix incorrect return value checks:

libre: #431
librem: baresip/rem#71
retest: baresip/retest#92
baresip: baresip/baresip#1955

[DenisPolygalov]

Thank you very much!

[DenisPolygalov]

I am sorry to tell you this but this is not fixed (does not work de facto). Specifically here:

re/src/thread/thread.c

Line 27 in 18fb840

if (err != thrd_success) {

for example if err is not zero then later

re/src/thread/thread.c

Line 37 in 18fb840

if (err)

mem_deref(m); will be called and non-zero err value returned ruining all the following code. The similarly wrong handling may be present in several other places, such as here:

re/src/jbuf/jbuf.c

Line 210 in 18fb840

if (err)

(if the for loop above succeeded). I was able to find only these two.

[sreimers]

Thanks for pointing this out. I refactored the err handling: #476