Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link creation with support for mobile safari #69

Closed
JannikStreek opened this issue Feb 6, 2022 · 1 comment · Fixed by #151
Closed

Link creation with support for mobile safari #69

JannikStreek opened this issue Feb 6, 2022 · 1 comment · Fixed by #151
Labels
enhancement New feature or request

Comments

@JannikStreek
Copy link
Member

JannikStreek commented Feb 6, 2022

Links inside a foreign object element seem not to work on mobile safari. Therefore, the link creation strategy has to leverage native svg link elements instead of making use of foreign object. This requires bigger changes in the underlying map lib. The alternative would be to add an onclick element, but this leaves room for possible XSS exploits.

Using native svg links means, that not these node are not editable anymore.

@JannikStreek JannikStreek changed the title Improve Link creation Link creation with support for mobile safari Feb 6, 2022
@JannikStreek JannikStreek added the enhancement New feature or request label Feb 10, 2022
@JannikStreek
Copy link
Member Author

Alternative idea: Link is not clickable directly. When the node is displayed, show a link symbol next to the node which is clickable. This also has the advantage not to accidentally click on a link if you wanted to move the node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant