Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Batch Passthru has an issues #6

Open
b-hayes opened this issue Oct 27, 2023 · 0 comments
Open

BUG: Batch Passthru has an issues #6

b-hayes opened this issue Oct 27, 2023 · 0 comments

Comments

@b-hayes
Copy link
Owner

b-hayes commented Oct 27, 2023

Seem there an issue with single quotes inside commands eg.

git commit -m 'some thing here'

results in the 'some thing here' part becoming 3 seperate paramters and ended up having to chane to escaped double quotes.

Also commands are too isolated indicating a different approach is needed.
eg, this fails because the cd command is isolated so the next command does not happen inside the expected directory.

        CLI::batchPassThru(
            [
                "git clone https://github.com/b-hayes/php-apache-template $name",
                "cd $name",
                "git branch"//list the branches before asking what to use.
            ]
        );

It would be better if all the commands are imploded with a set x so that the entire set stops on the first error.
I also thought about being able to specify a cleanup operation tho the user can just catch the exception and do it that way anyway. Perhaps think about it and change the exception type.

@b-hayes b-hayes changed the title Batch Passthru has an issue with each command being isolated. BUG: Batch Passthru has an issues Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant