Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix for secrets manager cannot be empty #232

Closed
MatejNedic opened this issue Feb 8, 2022 · 0 comments
Closed

Prefix for secrets manager cannot be empty #232

MatejNedic opened this issue Feb 8, 2022 · 0 comments
Labels
component: secrets-manager Secrets Manager integration related issue type: bug Something isn't working
Milestone

Comments

@MatejNedic
Copy link
Member

Type: Bug

Component:
"Secrets Manager"

Describe the bug
In code and docs
`* Prefix indicating first level for every property. Value must start with a forward

  • slash followed by a valid path segment or be empty. Defaults to "/secret".`
    Currently, this is not possible since validation will fail on an empty string.

Sample
Fix Validation for a prefix cannot be the empty string AwsSecretsManagerProperties.class Also change AwsSecretsManagerPropertySources.class method protected String getContext(String prefix, String context) to take changes into account.
Provide tests for all changes.

@MatejNedic MatejNedic added the component: secrets-manager Secrets Manager integration related issue label Feb 8, 2022
@github-actions github-actions bot added type: bug Something isn't working status: waiting-for-triage Team has not yet looked into this issue labels Feb 8, 2022
@MatejNedic MatejNedic added status: ideal-for-contribution We agree it's nice to have but it is not team priority and removed type: bug Something isn't working status: waiting-for-triage Team has not yet looked into this issue labels Feb 8, 2022
@MatejNedic MatejNedic added this to the 2.3.4 milestone Feb 8, 2022
@MatejNedic MatejNedic added the type: bug Something isn't working label Feb 8, 2022
@maciejwalkowiak maciejwalkowiak added status: pr submitted and removed status: ideal-for-contribution We agree it's nice to have but it is not team priority labels Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: secrets-manager Secrets Manager integration related issue type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants