Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Investigate if --region should drive region_name in boto3 Session creation #690

Closed
malachi-constant opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@malachi-constant
Copy link
Contributor

Issue

If using a partition outside of aws & AWS_DEFAULT_REGION is not set, seedfarmer will fail on Session creation as sts.get_caller_identity() will fail.

Decision point

  • Should --region in seedfarmer apply {manifest_path} --region cn-north-1 be passed to get_caller_identity()?

Potential Implementation

sts.get_caller_identity(region_name=region) if partition !="aws" else sts.get_caller_identity()
@malachi-constant
Copy link
Contributor Author

Will close this unless it's deemed necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant