aws-cloudfront-s3 README issue and cannot generate OAI resource

[JoeShi]

1. The README documentation of aws-cloudfront-s3 pattern is not correct.
2. The pattern did not create OAI anymore. I remember in early version, it do create the CloudFront OAI. Example can be seen here.

Reproduction Steps

In the documentation here. The type of cloudFrontDistributionProps is cloudfront.CloudFrontWebDistributionProps. However, in the code, it is cloudfront.DistributionProps.

Error Log

No.

Environment

• CDK CLI Version :
• CDK Framework Version:
• AWS Solutions Constructs Version :
• OS :
• Language :

Other

---

This is 🐛 Bug Report

[biffgaut]

Thanks - we'll take a look and see what's going on.

[hnishar]

Thanks for the feedback. Since v1.68.0, for all Cloudfront patterns, the underlying Cloudfront L2 CDK construct has changed from CloudFrontWebDistribution to Distribution See the Changelog and related issue We will update the READMEs

[hnishar]

One of the benefits of using the new L2 CDK construct was that it creates the OAI hence the aws-cloudfront-s3 pattern no longer needs to create the OAI, so if you change your input props from CloudFrontWebDistributionProps to DistributionProps you should see the OAI resource being created.

[hnishar]

JoeShi@ Documentation has been updated to reflect the updated Pattern Construct Props for aws-cloudfront-s3 pattern

https://docs.aws.amazon.com/solutions/latest/constructs/aws-cloudfront-s3.html#pattern-construct-props-5