Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX ECC key support #524

Merged
merged 18 commits into from
Nov 2, 2022
Merged

OSX ECC key support #524

merged 18 commits into from
Nov 2, 2022

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Oct 24, 2022

Issue #, if available:

Description of changes:
Handle ECC key implementation on XOS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DmitriyMusatkin
Copy link
Contributor

unit tests?

@xiazhvera xiazhvera changed the title XOS ECC key support OSX ECC key support Oct 26, 2022
AWS_ASSERT(decoded_key_buffer_list);

// A PEM file could contains multiple PEM data section. Try importing each PEM section until find the first
// succedd key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: succeed

Copy link
Contributor

@DmitriyMusatkin DmitriyMusatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix and ship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants