Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CI build fails due to missing secrets #1415

Closed
thinkski opened this issue Feb 23, 2022 · 9 comments
Closed

[BUG] CI build fails due to missing secrets #1415

thinkski opened this issue Feb 23, 2022 · 9 comments
Labels
bug Something isn't working pending-action

Comments

@thinkski
Copy link
Contributor

sample-check CI workflow is failing -- secrets are unavailable to CI:

Error: Input required and not supplied: aws-region
@thinkski thinkski added the bug Something isn't working label Feb 23, 2022
@disa6302
Copy link
Contributor

@thinkski ,

It is not a bug but the nature of GHA CI that does not allow using secrets on forked branches. We will look into it.

@thinkski
Copy link
Contributor Author

thinkski commented Feb 24, 2022

Thank you. It's showing up on PR CI builds (e.g. PR #1411)

@niyatim23
Copy link
Contributor

Hi @thinkski, thank you for bringing this up. I have an update to fix this in the develop branch. Can you please rebase from develop to see if it works for you?

@disa6302
Copy link
Contributor

disa6302 commented Mar 3, 2022

@thinkski ,
Can you please rebase your PR to pick the changes? Thank you!

@disa6302
Copy link
Contributor

disa6302 commented Mar 9, 2022

Closing due to no response.
@thinkski , please rebase your PR to include the change. We will reopen if the test still fails

@disa6302 disa6302 closed this as completed Mar 9, 2022
@thinkski
Copy link
Contributor Author

thinkski commented Mar 9, 2022

@disa6302 Sorry, didn't see this earlier. I rebased on the Feb 25 commit b4f4516. Unfortunately, still encounter same issue.

@disa6302
Copy link
Contributor

disa6302 commented Mar 9, 2022

We will look into this then. Thank you for confirming!

@disa6302 disa6302 reopened this Mar 9, 2022
@disa6302 disa6302 added pending-action and removed bug Something isn't working pending-response labels Mar 9, 2022
@disa6302 disa6302 added the bug Something isn't working label May 23, 2022
@github-actions
Copy link

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

@sirknightj
Copy link
Contributor

Should be fixed as of #1631 and #1634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending-action
Projects
None yet
Development

No branches or pull requests

4 participants