From ff9b8693a7e9679b34282194b61b10815c57984c Mon Sep 17 00:00:00 2001 From: William Armiros <54150514+willarmiros@users.noreply.github.com> Date: Thu, 11 Nov 2021 10:26:43 -0800 Subject: [PATCH 1/4] Reduce log level of target poller throwables --- .../amazonaws/xray/strategy/sampling/pollers/TargetPoller.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java index 223167ce..4c80b282 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java @@ -66,7 +66,7 @@ public void start() { try { pollManifest(); } catch (Throwable t) { - logger.error("Encountered error polling GetSamplingTargets: ", t); + logger.warn("Encountered error polling GetSamplingTargets: ", t); // Propagate if Error so executor stops executing. // TODO(anuraaga): Many Errors aren't fatal, this should probably be more restricted, e.g. // https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Throwables.java From 60dca53642b770a0903dee73518bb7e746908f74 Mon Sep 17 00:00:00 2001 From: William Armiros <54150514+willarmiros@users.noreply.github.com> Date: Thu, 11 Nov 2021 10:55:31 -0800 Subject: [PATCH 2/4] Update RulePoller.java --- .../amazonaws/xray/strategy/sampling/pollers/RulePoller.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java index 98842a8b..18897545 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java @@ -71,7 +71,7 @@ public void start() { try { pollRule(); } catch (Throwable t) { - logger.error("Encountered error polling GetSamplingRules: ", t); + logger.warn("Encountered error polling GetSamplingRules: ", t); // Propagate if Error so executor stops executing. // TODO(anuraaga): Many Errors aren't fatal, this should probably be more restricted, e.g. // https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Throwables.java From 095e91011ed64a740cbf88f09cba91216fb9e70b Mon Sep 17 00:00:00 2001 From: William Armiros <54150514+willarmiros@users.noreply.github.com> Date: Thu, 11 Nov 2021 17:23:25 -0800 Subject: [PATCH 3/4] Update RulePoller.java --- .../amazonaws/xray/strategy/sampling/pollers/RulePoller.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java index 18897545..bb2ee9e2 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java @@ -71,7 +71,7 @@ public void start() { try { pollRule(); } catch (Throwable t) { - logger.warn("Encountered error polling GetSamplingRules: ", t); + logger.info("Encountered error polling GetSamplingRules: ", t); // Propagate if Error so executor stops executing. // TODO(anuraaga): Many Errors aren't fatal, this should probably be more restricted, e.g. // https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Throwables.java From 2f01b03e7fec97941cf43e161a26832e8815e4fc Mon Sep 17 00:00:00 2001 From: William Armiros <54150514+willarmiros@users.noreply.github.com> Date: Thu, 11 Nov 2021 17:23:45 -0800 Subject: [PATCH 4/4] Update TargetPoller.java --- .../amazonaws/xray/strategy/sampling/pollers/TargetPoller.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java index 4c80b282..50991548 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java @@ -66,7 +66,7 @@ public void start() { try { pollManifest(); } catch (Throwable t) { - logger.warn("Encountered error polling GetSamplingTargets: ", t); + logger.info("Encountered error polling GetSamplingTargets: ", t); // Propagate if Error so executor stops executing. // TODO(anuraaga): Many Errors aren't fatal, this should probably be more restricted, e.g. // https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Throwables.java