Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A potential NPE in spring module #41

Closed
haotianw465 opened this issue Nov 15, 2018 · 1 comment
Closed

A potential NPE in spring module #41

haotianw465 opened this issue Nov 15, 2018 · 1 comment
Labels

Comments

@haotianw465
Copy link
Contributor

https://github.com/aws/aws-xray-sdk-java/blob/master/aws-xray-recorder-sdk-spring/src/main/java/com/amazonaws/xray/spring/aop/AbstractXRayInterceptor.java#L50

If the subsegment is null when there is no tracing context, this line will cause an NPE. In short-term the subsegment capture needs to do null-check. In long-term the recorder should deprecate the Subsegment beginSubsegment() and force all callers to use Optional<Subsegment> beginSubsegment().

@haotianw465
Copy link
Contributor Author

This issue is fixed as part of 2.1.0 release. See CHANGELOG for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant