Retry stats default documented incorrectly

[ssigwart]

Describe the issue

On https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#config-stats, for stats.retries, it says "Retry statistics are collected by default and returned."

That doesn't seem to be the case. I think the following code shows that the default for stats is false.

aws-sdk-php/src/ClientResolver.php

Lines 229 to 235 in dc9ac0a

	'stats' => [
	'type' => 'value',
	'valid' => ['bool', 'array'],
	'default' => false,
	'doc' => 'Set to true to gather transfer statistics on requests sent. Alternatively, you can provide an associative array with the following keys: retries: (bool) Set to false to disable reporting on retries attempted; http: (bool) Set to true to enable collecting statistics from lower level HTTP adapters (e.g., values returned in GuzzleHttp\TransferStats). HTTP handlers must support an http_stats_receiver option for this to have an effect; timer: (bool) Set to true to enable a command timer that reports the total wall clock time spent on an operation in seconds.',
	'fn' => [__CLASS__, '_apply_stats'],
	],

Therefore, I think the following code sets stats.retries to false.

aws-sdk-php/src/ClientResolver.php

Lines 911 to 917 in dc9ac0a

	$defaults = array_fill_keys(
	['http', 'retries', 'timer'],
	$value === true
	);
	$args['stats'] = is_array($value)
	? array_replace($defaults, $value)
	: $defaults;

Links

https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_configuration.html#config-stats