From 6024e43f937d5d10388f786203613a564f44c445 Mon Sep 17 00:00:00 2001 From: Chris Kerins Date: Thu, 5 Sep 2024 12:24:37 -0400 Subject: [PATCH 1/2] correct typo in route53 const This updates "@aws-cdk/aws-route53-patters" to "@aws-cdk/aws-route53-patterns" --- packages/aws-cdk-lib/cx-api/lib/features.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/aws-cdk-lib/cx-api/lib/features.ts b/packages/aws-cdk-lib/cx-api/lib/features.ts index 5ce4c237986d9..9221d4699b5f9 100644 --- a/packages/aws-cdk-lib/cx-api/lib/features.ts +++ b/packages/aws-cdk-lib/cx-api/lib/features.ts @@ -74,7 +74,7 @@ export const ENABLE_PARTITION_LITERALS = '@aws-cdk/core:enablePartitionLiterals' export const EVENTS_TARGET_QUEUE_SAME_ACCOUNT = '@aws-cdk/aws-events:eventsTargetQueueSameAccount'; export const ECS_DISABLE_EXPLICIT_DEPLOYMENT_CONTROLLER_FOR_CIRCUIT_BREAKER = '@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker'; export const S3_SERVER_ACCESS_LOGS_USE_BUCKET_POLICY = '@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy'; -export const ROUTE53_PATTERNS_USE_CERTIFICATE = '@aws-cdk/aws-route53-patters:useCertificate'; +export const ROUTE53_PATTERNS_USE_CERTIFICATE = '@aws-cdk/aws-route53-patterns:useCertificate'; export const AWS_CUSTOM_RESOURCE_LATEST_SDK_DEFAULT = '@aws-cdk/customresources:installLatestAwsSdkDefault'; export const DATABASE_PROXY_UNIQUE_RESOURCE_NAME = '@aws-cdk/aws-rds:databaseProxyUniqueResourceName'; export const CODEDEPLOY_REMOVE_ALARMS_FROM_DEPLOYMENT_GROUP = '@aws-cdk/aws-codedeploy:removeAlarmsFromDeploymentGroup'; From 06180271b33a1f12f5bcd8b8d386f12b95997683 Mon Sep 17 00:00:00 2001 From: Chris Kerins Date: Thu, 5 Sep 2024 16:18:21 -0400 Subject: [PATCH 2/2] updated patterns typo --- packages/aws-cdk-lib/aws-rds/adr/aurora-serverless-v2.md | 4 ++-- packages/aws-cdk-lib/aws-route53-patterns/README.md | 2 +- .../aws-route53-patterns/test/bucket-website-target.test.ts | 4 ++-- packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/aws-cdk-lib/aws-rds/adr/aurora-serverless-v2.md b/packages/aws-cdk-lib/aws-rds/adr/aurora-serverless-v2.md index a4fd2de2da5ff..3183bd591c48c 100644 --- a/packages/aws-cdk-lib/aws-rds/adr/aurora-serverless-v2.md +++ b/packages/aws-cdk-lib/aws-rds/adr/aurora-serverless-v2.md @@ -106,9 +106,9 @@ Serverless v2 can go up to 256GB memory. Anything above that needs to be provisi - But if using a db.r6g.16xlarge (512 GB) a serverles v2 instance can't scale to match -Out of the 4 common usage patters (peaks & valleys, outliers, random, and +Out of the 4 common usage patterns (peaks & valleys, outliers, random, and consistent), provisioned should be preferred for the consistent pattern. With -mixed use cluster you may have writers/readers that follow different patters. +mixed use cluster you may have writers/readers that follow different patterns. For example, you may have a writer that follows the `consistent` pattern, but a reader that follows the `outliers` pattern. In this case you may want to have a provisioned instance as the writer along with a provisioned reader in tier 0-1 diff --git a/packages/aws-cdk-lib/aws-route53-patterns/README.md b/packages/aws-cdk-lib/aws-route53-patterns/README.md index 93eb92bc8cf9a..f3f32414dde19 100644 --- a/packages/aws-cdk-lib/aws-route53-patterns/README.md +++ b/packages/aws-cdk-lib/aws-route53-patterns/README.md @@ -46,7 +46,7 @@ new patterns.HttpsRedirect(this, 'Redirect', { To have `HttpsRedirect` use the `Certificate` construct as the default created certificate instead of the deprecated `DnsValidatedCertificate` -construct, enable the `@aws-cdk/aws-route53-patters:useCertificate` +construct, enable the `@aws-cdk/aws-route53-patterns:useCertificate` feature flag. If you are creating the stack in a region other than `us-east-1` you must also enable `crossRegionReferences` on the stack. diff --git a/packages/aws-cdk-lib/aws-route53-patterns/test/bucket-website-target.test.ts b/packages/aws-cdk-lib/aws-route53-patterns/test/bucket-website-target.test.ts index 0cb56a8353210..87f51b01a5b17 100644 --- a/packages/aws-cdk-lib/aws-route53-patterns/test/bucket-website-target.test.ts +++ b/packages/aws-cdk-lib/aws-route53-patterns/test/bucket-website-target.test.ts @@ -155,7 +155,7 @@ test('throws when certificate in region other than us-east-1 is supplied', () => }).toThrow(/The certificate must be in the us-east-1 region and the certificate you provided is in us-east-2./); }); -describe('Uses Certificate when @aws-cdk/aws-route53-patters:useCertificate=true', () => { +describe('Uses Certificate when @aws-cdk/aws-route53-patterns:useCertificate=true', () => { test('explicit different region', () => { // GIVEN const app = new App({ @@ -292,6 +292,6 @@ describe('Uses Certificate when @aws-cdk/aws-route53-patters:useCertificate=true }), }); - }).toThrow(/When @aws-cdk\/aws-route53-patters:useCertificate is enabled, a region must be defined on the Stack/); + }).toThrow(/When @aws-cdk\/aws-route53-patterns:useCertificate is enabled, a region must be defined on the Stack/); }); }); diff --git a/packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md b/packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md index d911731f3b9f9..64d021225dd0d 100644 --- a/packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md +++ b/packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md @@ -41,7 +41,7 @@ Flags come in three types: | [@aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName](#aws-cdkaws-iamimportedrolestacksafedefaultpolicyname) | Enable this feature to by default create default policy names for imported roles that depend on the stack the role is in. | 2.60.0 | (fix) | | [@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy](#aws-cdkaws-s3serveraccesslogsusebucketpolicy) | Use S3 Bucket Policy instead of ACLs for Server Access Logging | 2.60.0 | (fix) | | [@aws-cdk/customresources:installLatestAwsSdkDefault](#aws-cdkcustomresourcesinstalllatestawssdkdefault) | Whether to install the latest SDK by default in AwsCustomResource | 2.60.0 | (default) | -| [@aws-cdk/aws-route53-patters:useCertificate](#aws-cdkaws-route53-pattersusecertificate) | Use the official `Certificate` resource instead of `DnsValidatedCertificate` | 2.61.0 | (default) | +| [@aws-cdk/aws-route53-patterns:useCertificate](#aws-cdkaws-route53-patternsusecertificate) | Use the official `Certificate` resource instead of `DnsValidatedCertificate` | 2.61.0 | (default) | | [@aws-cdk/aws-codedeploy:removeAlarmsFromDeploymentGroup](#aws-cdkaws-codedeployremovealarmsfromdeploymentgroup) | Remove CloudWatch alarms from deployment group | 2.65.0 | (fix) | | [@aws-cdk/aws-rds:databaseProxyUniqueResourceName](#aws-cdkaws-rdsdatabaseproxyuniqueresourcename) | Use unique resource name for Database Proxy | 2.65.0 | (fix) | | [@aws-cdk/aws-apigateway:authorizerChangeDeploymentLogicalId](#aws-cdkaws-apigatewayauthorizerchangedeploymentlogicalid) | Include authorizer configuration in the calculation of the API deployment logical ID. | 2.66.0 | (fix) | @@ -103,7 +103,7 @@ The following json shows the current recommended set of flags, as `cdk init` wou "@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker": true, "@aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName": true, "@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy": true, - "@aws-cdk/aws-route53-patters:useCertificate": true, + "@aws-cdk/aws-route53-patterns:useCertificate": true, "@aws-cdk/customresources:installLatestAwsSdkDefault": false, "@aws-cdk/aws-rds:databaseProxyUniqueResourceName": true, "@aws-cdk/aws-codedeploy:removeAlarmsFromDeploymentGroup": true, @@ -803,7 +803,7 @@ flag on a resource-by-resource basis to enable it if necessary. **Compatibility with old behavior:** Set installLatestAwsSdk: true on all resources that need it. -### @aws-cdk/aws-route53-patters:useCertificate +### @aws-cdk/aws-route53-patterns:useCertificate *Use the official `Certificate` resource instead of `DnsValidatedCertificate`* (default)