Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested cdk Python dependencies are not explicitly versioned #5460

Closed
chamcca opened this issue Dec 17, 2019 · 1 comment
Closed

Nested cdk Python dependencies are not explicitly versioned #5460

chamcca opened this issue Dec 17, 2019 · 1 comment
Assignees
Labels
bug This issue is a bug. language/python Related to Python bindings management/devenv Related to CDK development/build environment needs-triage This issue or PR still needs to be triaged.

Comments

@chamcca
Copy link
Contributor

chamcca commented Dec 17, 2019

When explicitly setting the version of cdk dependencies for python projects, nested dependencies used by those cdk packages don't use an explicit version ( == ) and instead use a greater-than-or-equal version ( >= ).

This causes unanticipated updates to the cdk packages even when explicitly setting the version.

For example, from a pip install log. Here we explicitly declare a dependency on aws-cdk.core==1.18.0, but the core has a dependency on aws-cdk.cx-api>=1.18.0 which then installs 1.19.0. This happens for all nested dependencies.

Collecting aws-cdk.cx-api>=1.18.0,~=1.18 (from aws-cdk.core==1.18.0->aws-emr-launch==0.3.1.dev0)

Reproduction Steps

in requirements.txt:

aws-cdk.core==1.18.0
aws-cdk-aws.s3==1.18.0

Then:

pip install -e requirements.txt

Error Log

From the example above:

ERROR: aws-cdk-aws-iam 1.19.0 has requirement aws-cdk.core>=1.19.0,~=1.19, but you'll have aws-cdk-core 1.18.0 which is incompatible.
ERROR: aws-cdk-aws-events 1.19.0 has requirement aws-cdk.core>=1.19.0,~=1.19, but you'll have aws-cdk-core 1.18.0 which is incompatible.
ERROR: aws-cdk-aws-kms 1.19.0 has requirement aws-cdk.core>=1.19.0,~=1.19, but you'll have aws-cdk-core 1.18.0 which is incompatible.

Environment

  • CLI Version : 1.18.0
  • Framework Version: 1.180.0
  • OS : OSX
  • Language : Python

Other


This is 🐛 Bug Report

@chamcca chamcca added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 17, 2019
@SomayaB SomayaB added language/python Related to Python bindings management/devenv Related to CDK development/build environment labels Dec 18, 2019
@RomainMuller
Copy link
Contributor

This is a duplicate of #3517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. language/python Related to Python bindings management/devenv Related to CDK development/build environment needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants