-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CdkPipelines: UpdatePipeline stage still running standard:6.0 w/ node16 and fails #33494
Comments
+1 We are also running into this |
I just realize that we're already customizing the installCommands for all our Builds. That's where the |
The warning banner is definitely new, that was not intentional. It should not actually cause anything to fail though. |
For context, we aren't married to
|
The issue is not reproducible with the latest version of aws-cdk-lib: 2.179.0 which is using |
@mrlikl Thankd for the verification. @ahammond Please validate this using latest version of Thanks, |
Oh, it's nice to see the cli and the lib finally separated. As noted above, I first attempted to upgrade aws-cdk-lib to latest. It's currently runnign 2.179.0. I have also grovelled my pnpm-lock.yaml to confirm that is the only version installed. When I run
I confirm that this is what is deployed. When I look at the deployed template in Cfn console, I see
So... It look like this isn't getting updated. |
I'm going to tear down and re-deploy this stack to see if it get the |
Oh! Found it! We have a library which wraps the cdk-pipelines stuff to handle a whole bunch of things including bumping the default for the BuildImage. We did this when the default was 5 to pick up 6 earlier... and haven't updated it since. Fixed. |
Comments on closed issues and PRs are hard for our team to see. |
Describe the bug
This breaks cdk pipelines at the UpdatePipeline stage:
Regression Issue
Last Known Working CDK Version
none
Expected Behavior
The buildspec of the Build stage of cdk pipelines includes a
"test -f .nvmrc && n auto || true",
, but the UpdatePipeline stage does not. I would expect ALL stages of the pipeline to respect the.nvmrc
file, when it exists.I would expect ALL stages to run supported versions of node by default.
Current Behavior
Attempts to run node16 and breaks.
Reproduction Steps
Deploy a CDK pipeline, trigger a run and watch it fail. I'm seeing failures across > 100 pipelines in our org at this time.
Possible Solution
Add
"test -f .nvmrc && n auto || true",
to the UpdatePipeline stage.Default to using supported node (ideally latest node)
Additional Information/Context
No response
CDK CLI Version
2.1000.0 (build 1c60bc6) --- uh... this is suprising to me.
Framework Version
tested on 2.179.0
Node.js Version
22.14.0 on laptop, apparently 16.? in CodePipeline
OS
MacOS
Language
TypeScript
Language Version
TypeScript (5.7.3)
Other information
No response
The text was updated successfully, but these errors were encountered: