Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ecr-assets: support for .containerignore file and / or alternative ignore file #33426

Open
2 tasks
koshic opened this issue Feb 13, 2025 · 1 comment
Open
2 tasks
Labels
@aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@koshic
Copy link

koshic commented Feb 13, 2025

Describe the feature

Podman supports two different ignore file variants: .dockerignore (for compatibility reasons) and .containerignore, see https://docs.podman.io/en/stable/markdown/podman-build.1.html#files. Moreover, it's possible to provide alternative ignore file.

But, .dockerignore file name is hardcoded in aws cdk:

const ignore = path.join(dir, '.dockerignore');

Use Case

.containerignore natively supported by Podman is ignored by aws cdk, which force me to rename file or use include / exclude properties.

Proposed Solution

To add ability to specify alternative ignore file (as it already implemented for Dockerfile itself), and / or support vendor-free file names by default (Containerfile / .containerignore).

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.178.2

Environment details (OS name and version, etc.)

mac os

@koshic koshic added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 13, 2025
@github-actions github-actions bot added the @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets label Feb 13, 2025
@pahud pahud self-assigned this Feb 13, 2025
@pahud
Copy link
Contributor

pahud commented Feb 13, 2025

Makes sense for me. We haven't fully tested with podman but given its popularity we should consider this. Please help us prioritize 👍 and we welcome a PR to move this forward.

@pahud pahud added p3 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 13, 2025
@pahud pahud removed their assignment Feb 13, 2025
@pahud pahud added the effort/medium Medium work item – several days of effort label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

2 participants