Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-lib/aws-apigatewayv2: ApiMapping module is not removing mapping path for custom domains #32401

Closed
1 task
Madhan-droid opened this issue Dec 6, 2024 · 2 comments
Assignees
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@Madhan-droid
Copy link

Describe the bug

Hello Everyone,
I was working on mapping my aws apigateway with custom domain name. I was able to create the api mapping using aws cdk. But I'm not able to remove the api mapping path even after removing ApimappingKey from the deployment code.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

Initially I created the custom domain with no path.

Here's the code snippet I used for creating the api maping.
image

It created the api mapping with no path.

In next deployment I updated the code like this:
image

I can see the mapping with path:
image

But I removed the apiMappingKey from the deployment code then deployed it.

I'm assuming it should remove the path from the mapping.

Current Behavior

I can see the logs of the apimapping being updated:
image

But the mapping path is not removed.
image

Is it the default behaviour of aws cdk?

Reproduction Steps

I have mentioned everything above.

Possible Solution

The mapping should be removed.

Additional Information/Context

No response

CDK CLI Version

2.170.0

Framework Version

No response

Node.js Version

v22.11.0

OS

Windows 10

Language

TypeScript

Language Version

No response

Other information

No response

@Madhan-droid Madhan-droid added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 6, 2024
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Dec 6, 2024
@khushail khushail added needs-reproduction This issue needs reproduction. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 6, 2024
@khushail khushail self-assigned this Dec 6, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-reproduction This issue needs reproduction. labels Dec 11, 2024
@khushail
Copy link
Contributor

khushail commented Dec 12, 2024

Hi @Madhan-droid , thanks for reaching out. Could you share the result of cdk diff when you removed the path from the code and re-deployed it ? It would also be helpful to look at synthesized template before and after the change

@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 12, 2024
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants