Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws_docdb): (Propogate maintenace window settings to cluster's instances) #30391

Open
1 of 2 tasks
nritholtz opened this issue May 30, 2024 · 1 comment
Open
1 of 2 tasks
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@nritholtz
Copy link

Describe the feature

Currently if you specified a preferredMaintenanceWindow on a cdk.aws_docdb.DatabaseCluster construct, it will only apply it to the cluster level. See

dbInstanceClass: databaseInstanceType(props.instanceType),
. Add support for instance's window as well.

Use Case

This is creating unexpected maintenance events when you declared the window at the cluster level, and assumed instances would follow suit.

Proposed Solution

We should allow if you specify preferredMaintenanceWindow on cluster level, it should apply to instances as well.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.142.1

Environment details (OS name and version, etc.)

Mac 13.5.2

@nritholtz nritholtz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 30, 2024
@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label May 30, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 30, 2024
@khushail khushail self-assigned this May 30, 2024
@khushail khushail added p2 effort/small Small work item – less than a day of effort labels May 30, 2024
@khushail
Copy link
Contributor

Hey @nritholtz , thanks for submitting this FR. I am not sure how this should be implemented as by passing it to instanceprops or creating a flag, however suggestions and contributions are welcome from the community!

@khushail khushail removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label May 30, 2024
@khushail khushail removed their assignment May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants