Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a role allow multiple conditioned roles in assumeby property #3006

Closed
1 of 5 tasks
NetaNir opened this issue Jun 21, 2019 · 1 comment
Closed
1 of 5 tasks
Assignees
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management closing-soon This issue will automatically close in 4 days unless further comments are made. duplicate This issue is a duplicate. feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@NetaNir
Copy link
Contributor

NetaNir commented Jun 21, 2019

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.
  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce

When creating an IAM Role the assumeby property only allows a single role or multiple roles via the CompositePrincipal but the CompositePrincipal doesn't allow conditions and throws:

Components of a CompositePrincipal must not have conditions

This can be accomplished by using the L1 CfnRole assumeRolePolicyDocument property which accepts a policy statement that allows multiple roles

  • What is the expected behavior (or behavior of feature suggested)?

could be nice to have assumeby accept an array of principals roles or have CompositePrincipal allow conditions

  • What is the motivation / use case for changing the behavior or adding this feature?
    I can add all of the principals roles in the Role creation

  • Please tell us about your environment:

    • CDK CLI Version:0.35
    • Module Version: 0.35
    • OS: OSX
    • Language: TS
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

@NGL321 NGL321 added feature-request A feature should be added or improved. @aws-cdk/aws-iam Related to AWS Identity and Access Management labels Jun 24, 2019
@NGL321
Copy link
Contributor

NGL321 commented Jun 24, 2019

I believe this is a duplicate of issue #1578. I am marking this for closing, please add a "+1" to the other issue to bump it. Otherwise let me know here if you think your issue is distinct and I will keep this open!

Please bear in mind however, we are working hard to stabilize the CDK APIs and tuning them to meet our consistency guidelines. While we work on getting the APIs aligned with our guidelines, we are pausing work on most community PRs and feature-requests. Please continue to report issues and submit feature requests, of course. We expect to get back to work on community input within a few weeks.

@NGL321 NGL321 added closing-soon This issue will automatically close in 4 days unless further comments are made. duplicate This issue is a duplicate. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management closing-soon This issue will automatically close in 4 days unless further comments are made. duplicate This issue is a duplicate. feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

4 participants