Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bootstrap stack): (Abort failed multipart upload after 7 days) #29045

Closed
1 of 2 tasks
nikhil-zadoo opened this issue Feb 9, 2024 · 5 comments · Fixed by #31956
Closed
1 of 2 tasks

(Bootstrap stack): (Abort failed multipart upload after 7 days) #29045

nikhil-zadoo opened this issue Feb 9, 2024 · 5 comments · Fixed by #31956
Assignees
Labels
@aws-cdk/aws-s3 Related to Amazon S3 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI

Comments

@nikhil-zadoo
Copy link

Describe the feature

Enable lifecycle rule to abort multipart uploads after 7 days for assets bucket rolled out with CDK bootstrap.

Use Case

I realized the configuration after trusted advisor rolled out a new check. Reference : https://docs.aws.amazon.com/awssupport/latest/user/cost-optimization-checks.html#s3-incomplete-multipart-upload-abort-config

Makes sense that any failed multipart uploads are deleted after 7 days. This is to ensure that the failed parts don't unnecessarily take up s3 space and cause costs.

Proposed Solution

Enable lifecycle rule to delete failed multipart uploads in case of s3 assets bucket rolled out with cdk bootstrap.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.114.1

Environment details (OS name and version, etc.)

MACOS, LINUX

@nikhil-zadoo nikhil-zadoo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 9, 2024
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Feb 9, 2024
@nikhil-zadoo nikhil-zadoo changed the title (module name): (short issue description) (Bootstrap stack): (Abort failed multipart upload after 7 days) Feb 9, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Feb 9, 2024
@pahud
Copy link
Contributor

pahud commented Feb 9, 2024

This is an awesome feature! Thank you and we look forward to your upcoming PR.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 9, 2024
@nikhil-zadoo
Copy link
Author

#29046 is created for the issue

@tfentonz
Copy link

tfentonz commented Apr 8, 2024

+1 I would like to resolve the Trusted Advisor Cost Optimization S3 Incomplete Multipart Upload Abort Configuration check for CDK asset buckets.

@rix0rrr rix0rrr added p1 effort/small Small work item – less than a day of effort and removed p2 effort/medium Medium work item – several days of effort labels Oct 28, 2024
@sumupitchayan sumupitchayan self-assigned this Oct 29, 2024
@mergify mergify bot closed this as completed in #31956 Oct 31, 2024
@mergify mergify bot closed this as completed in b800da8 Oct 31, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-s3 Related to Amazon S3 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
5 participants