-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-cdk-lib: NODEJS_LATEST still points to nodejs18.x #28125
Comments
Hi @MunchyYDL , Thnaks for reaching out. There is already work being done on upgrading the lambda runtime to NodeJS20 as the latest. It is being tracked here. |
HI @khushail, thanks for the information, I will close my own attempts to fix this then, and leave it to you guys! 👍 |
|
Reopening this because #27003 tracks CDK's transition from node18 to node20 in our underlying custom resources. This ticket tracks |
Sorry, I thought you meant that there were other issues tracking this, I just wanted to clean up after myself. And oh, do you have any more information about when That was actually some of my initial concerns, that I couldn't find any rules about if |
@kaizencc Is this still on your radar? Also, I can't find any info that Node 20 is only available in certain regions (e.g. https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html, or https://aws.amazon.com/blogs/compute/node-js-20-x-runtime-now-available-in-aws-lambda/). Can you confirm that this is still the case, and maybe point me to a source? |
Hey @MunchyYDL and @unstubbable, this blog post is where I see a reference to Node 20 not being available in all regions. Thank you for bringing this issue up, and it is on our radar. We have some ideas on making |
Selfishly, I'd want NODEJS_LATEST to always point to the latest runtime available in most regions, especially not including GovCloud or China. That said, I could see the broad usefulness of the variable to ensure random Lambda functions, like custom resources, that don't get updated much, are always on at least a supported version. Given that, I might suggest a new variable: |
@automartin5000 I'm working on a PR that adds region awareness for node runtimes to our custom resources. I think it would make sense to point |
The Found no public information about the china regions 🤷 Region awareness for (node) runtimes would be great though. |
Describe the bug
NODEJS_LATEST points to
nodejs18.x
even thoughnodejs20.x
is available.Not exactly sure if this should be considered a bug or a feature request?
I tried searching for any information regarding if the NODEJS_LATEST value change should be delayed because of some reason but couldn't find anything. Tried to ask about it here as well #28046, but haven't received any response there yet.
Expected Behavior
NODEJS_LATEST should return
nodejs20.x
Current Behavior
NODEJS_LATEST returns
nodejs18.x
This is where you can find the code:
aws-cdk-lib/aws-lambda/lib/runtime.js
Reproduction Steps
Just use the NODEJS_LATEST
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.110.1 (build 0d37f0d)
Framework Version
No response
Node.js Version
v20.9.0
OS
macOS
Language
TypeScript
Language Version
TypeScript v5.2.2
Other information
No response
The text was updated successfully, but these errors were encountered: