Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cognito): UserPoolGroup CDK construct #21026

Closed
1 of 2 tasks
SamStephens opened this issue Jul 7, 2022 · 5 comments · Fixed by #31351
Closed
1 of 2 tasks

(cognito): UserPoolGroup CDK construct #21026

SamStephens opened this issue Jul 7, 2022 · 5 comments · Fixed by #31351
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@SamStephens
Copy link
Contributor

SamStephens commented Jul 7, 2022

Describe the feature

Provide a high level construct for Cognito user pool groups.

Use Case

If we want to use CDK to create Cognito Groups, we have to use Level 1/Cfn constructs.

Proposed Solution

Create a high-level CDK Construct for AWS::Cognito::UserPoolGroup. Possibly also add an add_group method to UserPool.

Other Information

Reopening the recently auto-closed issue #13413.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.31.0, Python

Environment details (OS name and version, etc.)

Ubuntu 20.04 on WSL 2 within Windows 10.0.19044

@SamStephens SamStephens added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 7, 2022
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Jul 7, 2022
@corymhall
Copy link
Contributor

This issue has been classified as p2. That means a workaround is available or it is deemed a nice-to-have feature. Given the amount of work there is to do and the relative priority of this issue, the CDK team is unlikely to address it. That does not mean the issue will never be fixed! If someone from the community submits a PR to fix this issue, and the PR is small and straightforward enough, and meets the quality bars to be reviewed and merged with little effort we will accept that PR. PRs that do not build or need complex or multiple rounds of reviews are unlikely to be merged and will be closed to keep our backlog manageable.

In the mean time, remember that you can always use the escape hatch (https://docs.aws.amazon.com/cdk/v2/guide/cfn_layer.html) mechanism to have fine control over the CloudFormation output you want. We will keep the issue open for discoverability, to collect upvotes, and to facilitate discussion around this topic.

We use +1s on this issue to help prioritize our work, and are happy to re-evaluate the prioritization of this issue based on community feedback. You can reach out to the cdk.dev community on Slack (https://cdk.dev/) to solicit support for reprioritization.

@SamStephens it looks like you may be interested in contributing this feature. It looks like
UserPoolGroup may be a pretty straightforward construct, but if it ends up being more complicated
I would recommend starting the PR with just the README changes so that we can agree on the design
before starting on the implementation.

@corymhall corymhall added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 8, 2022
@corymhall corymhall removed their assignment Jul 8, 2022
@vumdao
Copy link

vumdao commented Aug 1, 2022

Using CfnUserPoolGroup is ok but hope we can use L2 at all

@0xdevalias
Copy link
Contributor

0xdevalias commented May 23, 2023

CfnUserPoolGroup Example:

const cfnFooGroup = new CfnUserPoolGroup(this, 'FooUserGroup', {
  userPoolId: userPool.userPoolId,
  groupName: `${userPool.userPoolId}_Foo`,
  description: 'Group for users who were registered through Foo',
})

@pahud pahud added p3 and removed p2 labels Jun 11, 2024
@mergify mergify bot closed this as completed in #31351 Oct 31, 2024
@mergify mergify bot closed this as completed in 408b20f Oct 31, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants