Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old release scripts #15595

Closed
skinny85 opened this issue Jul 15, 2021 · 1 comment
Closed

Remove the old release scripts #15595

skinny85 opened this issue Jul 15, 2021 · 1 comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@skinny85
Copy link
Contributor

In #15331, we introduced a new tool, cdk-release, responsible for performing the version bump, generating the Changelog, etc. However, we still left the old logic intact (accessible by setting the LEGACY_BUMP environment variable), in case the new tool had some bugs.

Now that we have done a few releases using the new tool, it seems to be battle-tested enough, and we're ready to remove the old release process:

  1. Remove the code in the LEGACY_BUMP branch of the bump.js script. We should probably change the bump.sh script to call the cdk-release tool directly, and remove the bump.js script completely.
  2. We can remove this workaround.
  3. We can remove this workaround (it's on the v2-main branch).
  4. We can remove the dependency on the standard-version package.
@skinny85 skinny85 added aws-cdk-lib Related to the aws-cdk-lib package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jul 15, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

1 participant