Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] support settings certificate arn for cloudfront distribution #304

Closed
stevie- opened this issue Nov 27, 2024 · 5 comments
Closed

Comments

@stevie-
Copy link

stevie- commented Nov 27, 2024

Support setting certificate arn for cloudfront distribution.

Parameters:
  AcmCertificateArn:
    Type: String
    Description: The ARN of the ACM certificate to use for the CloudFront distribution
    Default: ""

      DistributionConfig:
        HttpVersion: http2and3
        PriceClass: PriceClass_100
        ViewerCertificate:
          AcmCertificateArn: !Ref AcmCertificateArn
          SslSupportMethod: sni-only
          MinimumProtocolVersion: TLSv1.2_2021
        Aliases: !Ref AlternateDomainNames
@ottokruse
Copy link
Collaborator

Also gave it a thumbs up! :)

@ottokruse
Copy link
Collaborator

Interested in sending a PR?

@ottokruse
Copy link
Collaborator

Note that new deployments to the serverless repo are currently blocked because of #300

@ottokruse
Copy link
Collaborator

ottokruse commented Jan 2, 2025

It's on main master (yes, old repo) now!

But as mentioned, can't add this to the serverless repo because of #300 Do you use that?

@stevie-
Copy link
Author

stevie- commented Jan 2, 2025

We don't use sam.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants