Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump react-native to 0.72.x #188

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jul 22, 2024

Issue #, if available:

Description of changes:
Bumps react-native to 0.72.x

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

socket-security bot commented Jul 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/metro-react-native-babel-preset@0.76.9 environment Transitive: filesystem, network, shell, unsafe +120 15.7 MB metro-bot
npm/react-native@0.72.15 environment, network Transitive: eval, filesystem, shell, unsafe +500 159 MB react-native-bot

🚮 Removed packages: npm/metro-react-native-babel-preset@0.70.4, npm/react-native@0.71.19

View full report↗︎

@trivikr
Copy link
Contributor Author

trivikr commented Jul 22, 2024

Following errors are thrown on iOS:

 ERROR  Error: Requiring unknown module "undefined". If you are sure the module exists, try restarting Metro. You may also want to run `yarn` or `npm install`., js engine: hermes

 LOG  Running "reactnative" with {"rootTag":1,"initialProps":{}}

 ERROR  Invariant Violation: "reactnative" has not been registered. This can happen if:
* Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project.
* A module failed to load due to an error and `AppRegistry.registerComponent` wasn't called., js engine: hermes
Details Screenshot 2024-07-21 at 11 11 10 PM Screenshot 2024-07-21 at 11 11 20 PM

@trivikr
Copy link
Contributor Author

trivikr commented Jul 22, 2024

The App.js is likely going to be changed to App.tsx Doesn't help.

Rendering errors are thrown after removing old styles

Details Screenshot 2024-07-21 at 11 29 19 PM

@trivikr trivikr force-pushed the bump-react-native-0.72.x branch from 88b8cd3 to 05d039b Compare July 22, 2024 22:38
@trivikr
Copy link
Contributor Author

trivikr commented Jul 23, 2024

The issues with Metro were resolved by reverting back to old Metro Config.

@trivikr trivikr marked this pull request as ready for review July 23, 2024 00:56
@trivikr trivikr requested a review from a team as a code owner July 23, 2024 00:56
@trivikr trivikr merged commit 0d55190 into main Jul 23, 2024
2 checks passed
@trivikr trivikr deleted the bump-react-native-0.72.x branch July 23, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant