Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with xray 2.6.0 #88

Closed
Nr18 opened this issue Jul 16, 2020 · 4 comments
Closed

Compatibility with xray 2.6.0 #88

Nr18 opened this issue Jul 16, 2020 · 4 comments
Assignees
Labels
dependencies Pull requests that update a dependency file feature-request feature request

Comments

@Nr18
Copy link

Nr18 commented Jul 16, 2020

Is your feature request related to a problem? Please describe.
We are currently using aws-xray-sdk-python 2.6.0 and I wanted to test the power tools but it seems that this project is not compatible with the latest release of the X-Ray SDK.

Describe the solution you'd like
This project to stay up to date with the new SDK releases, 2.6.0 has been released more than a month ago.

Describe alternatives you've considered
Downgrading the SDK but we want to keep up with the latest versions of packages to reduce bugs/vulnerabilities and benefit from new features.

Additional context
Not sure if it has a compatibility reason or just done out of foresight: ~= 2.5.0 see https://github.com/awslabs/aws-lambda-powertools-python/blob/0670e5efa09b60f0dd6d040a1a3b37225c94b516/pyproject.toml#L22

@Nr18 Nr18 added feature-request feature request triage Pending triage from maintainers labels Jul 16, 2020
@triage-new-issues triage-new-issues bot removed the triage Pending triage from maintainers label Jul 16, 2020
@heitorlessa
Copy link
Contributor

Hi Joris - Thanks for opening up the issue -- Its definitely an oversight, as we should be compatible with any 2.* version

If you could do a quick PR I'd gladly accept it, or I can do this next week :)

Thanks again!

@Nr18
Copy link
Author

Nr18 commented Jul 16, 2020

@heitorlessa not sure if this is the only place where it needs to be updated but I created #89. Although you mentioned any 2.* version I used 2.5.0 as the first one since that was already set.

@heitorlessa heitorlessa self-assigned this Jul 16, 2020
@heitorlessa heitorlessa added dependencies Pull requests that update a dependency file area/tracer labels Jul 16, 2020
@heitorlessa
Copy link
Contributor

Just released 1.0.2 with this fix - Thanks a lot for the contribution :)

PS: I think I finally remember why your login looked familiar. @Nr18 .... it was back then with the cookiecutter for SAM Python, which I intend to update to use this library now ;)

Closing this now, and thank you again!

@Nr18
Copy link
Author

Nr18 commented Jul 16, 2020

That is correct, I noticed that when you responded to this issue.

Happy to help out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature-request feature request
Projects
Development

No branches or pull requests

2 participants