Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix e2e tests in Idempotency Redis persistent storage #5279

Closed
leandrodamascena opened this issue Oct 1, 2024 · 2 comments · Fixed by #5280
Closed

Bug: Fix e2e tests in Idempotency Redis persistent storage #5279

leandrodamascena opened this issue Oct 1, 2024 · 2 comments · Fixed by #5280
Labels
bug Something isn't working triage Pending triage from maintainers

Comments

@leandrodamascena
Copy link
Contributor

Expected Behaviour

In this PR #5251 we introduced new tests in the Idempotency utility, but Redis is failing because it needs a proper connection handler.

Current Behaviour

Error

FAILED tests/e2e/idempotency_redis/test_idempotency_redis.py::test_response_hook_idempotency - RuntimeError: Function failed invocation: {"errorMessage": "Failed to save in progress record to idempotency store - (Parameter validation failed:\nInvalid length for parameter TableName, value: 0, valid min length: 1)", "errorType": "IdempotencyPersistenceLayerError", "stackTrace": ["  File \"/opt/python/aws_lambda_powertools/middleware_factory/factory.py\", line 137, in wrapper\n    response = middleware()\n", "  File \"/opt/python/aws_lambda_powertools/utilities/idempotency/idempotency.py\", line 101, in idempotent\n    return idempotency_handler.handle()\n", "  File \"/opt/python/aws_lambda_powertools/utilities/idempotency/base.py\", line 124, in handle\n    return self._process_idempotency()\n", "  File \"/opt/python/aws_lambda_powertools/utilities/idempotency/base.py\", line 150, in _process_idempotency\n    raise IdempotencyPersistenceLayerError(\n"]}
``
`

### Code snippet

```python
No snippet

Possible Solution

Fix tests

Steps to Reproduce

Run e2e tests

Powertools for AWS Lambda (Python) version

latest

AWS Lambda function runtime

3.12

Packaging format used

Lambda Layers

Debugging logs

No response

Copy link
Contributor

github-actions bot commented Oct 1, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This is now released under 3.1.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Oct 8, 2024
@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Pending triage from maintainers
Projects
Status: Shipped
Development

Successfully merging a pull request may close this issue.

1 participant