Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Add nofollow & noopener to external links #2830

Closed
2 tasks done
sthulb opened this issue Jul 24, 2023 · 6 comments · Fixed by #2842
Closed
2 tasks done

Maintenance: Add nofollow & noopener to external links #2830

sthulb opened this issue Jul 24, 2023 · 6 comments · Fixed by #2842
Labels
internal Maintenance changes

Comments

@sthulb
Copy link
Contributor

sthulb commented Jul 24, 2023

Why is this needed?

It's possible that Google and other search engines have given aws.dev special status. Malicious actors could use this to raise the profile of their SEO standing.

Which area does this relate to?

Other

Solution

To combat any potential for this being an issue, we should add rel="nofollow noopener" to external links.

Acknowledgment

@sthulb sthulb added triage Pending triage from maintainers internal Maintenance changes labels Jul 24, 2023
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Jul 24, 2023
@heitorlessa
Copy link
Contributor

heitorlessa commented Jul 24, 2023

good catch! It's a good candidate to create our first markdownlint custom rule - we'll surely miss this eventually

@leandrodamascena
Copy link
Contributor

When I was working on issue #2260 I spent time researching this and it may not be necessary to add the nofollow attribute as it is automatically added by newer browsers.

References:
https://chromestatus.com/feature/6140064063029248
https://bugs.chromium.org/p/chromium/issues/detail?id=898942
https://bugs.webkit.org/show_bug.cgi?id=155166
https://bugzilla.mozilla.org/show_bug.cgi?id=1222516

@sthulb
Copy link
Contributor Author

sthulb commented Jul 24, 2023

Cool, we can drop noopener then and just add nofollow which is observed by search engines

@leandrodamascena
Copy link
Contributor

Nice @sthulb! Can you send the PR or do we wait a bit and do it next week? Just let me know.

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jul 26, 2023
@heitorlessa heitorlessa moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Aug 1, 2023
@github-actions
Copy link
Contributor

This is now released under 2.23.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
Status: Shipped
Development

Successfully merging a pull request may close this issue.

3 participants