Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow non-JSON schemas in Feature flags #1170

Closed
whardier opened this issue Dec 13, 2021 · 6 comments
Closed

Feature request: Allow non-JSON schemas in Feature flags #1170

whardier opened this issue Dec 13, 2021 · 6 comments
Labels
feature_flags Feature Flags utility feature-request feature request rejected

Comments

@whardier
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Allow for callable transforms to be used (as well as the str "shortcuts").

Describe the solution you'd like

Pass something like yaml.loads or load_my_really_cool_serialized_data callable as transform argument toward parameter store fetches.

Describe alternatives you've considered

Due to how feature flags works.. we are unable to use yaml or any other loader before processing happens and this needs patched. Other approaches for parameters is to not pass a transform and then transform after the fact.

Additional context

PR already written up.

@heitorlessa heitorlessa transferred this issue from aws-powertools/powertools-lambda-python Dec 22, 2021
@heitorlessa heitorlessa changed the title Make parameter transforms callable (and retain str capabilities) Feature flags: Allow non-JSON schemas Dec 22, 2021
@michaelbrewer
Copy link
Contributor

@whardier - shouldn't this about be resolved for feature flags?

@whardier
Copy link
Contributor Author

Referring to #804?

No this issue relates to the payload coming from appconfig rather than subobjects.

@heitorlessa heitorlessa transferred this issue from aws-powertools/powertools-lambda Apr 28, 2022
@heitorlessa heitorlessa added the feature-request feature request label Jun 13, 2022
@heitorlessa heitorlessa added feature_flags Feature Flags utility and removed area/feature_flags labels Nov 9, 2022
@heitorlessa
Copy link
Contributor

Update: Now that feature flags is stable (one incoming change for Time-based feature), I'd love to see a RFC on this for a Loader interface so to allow any input (YAML, TOML, canonical, etc.).

@heitorlessa heitorlessa added help wanted Could use a second pair of eyes/hands need-customer-feedback Requires more customers feedback before making or revisiting a decision labels Dec 15, 2022
@sthulb sthulb moved this from Triage to Ideas in Powertools for AWS Lambda (Python) Jun 19, 2023
@leandrodamascena
Copy link
Contributor

Hi @whardier! Hope things are going well over there.

It's been a long time since we've had updates on this issue, and we'd like to know if you can work on an RFC to implement this in Powertools. As @heitorlessa mentioned, the Feature Flags is stable and we have support to TimeBased - #1554 and Module Range - #2003, it can be awesome to add support for input other than JSON only.

Thank you.

@leandrodamascena leandrodamascena moved this from Ideas to Pending customer in Powertools for AWS Lambda (Python) Jun 20, 2023
@heitorlessa heitorlessa moved this from Pending customer to Backlog in Powertools for AWS Lambda (Python) Jul 10, 2023
@heitorlessa heitorlessa changed the title Feature flags: Allow non-JSON schemas Feature request: Allow non-JSON schemas in Feature flags Jul 10, 2023
@heitorlessa heitorlessa removed the need-customer-feedback Requires more customers feedback before making or revisiting a decision label Jul 10, 2023
@heitorlessa
Copy link
Contributor

We're closing feature requests older than a year that haven't received enough customers +1 or that we were unable to prioritize. For newer customers interested in, please feel free to comment and we can reopen it.

@heitorlessa heitorlessa closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (Python) Jul 19, 2023
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jul 21, 2023
@dreamorosi dreamorosi added rejected and removed help wanted Could use a second pair of eyes/hands need-rfc labels Jan 22, 2025
@dreamorosi dreamorosi moved this from Shipped to Closed in Powertools for AWS Lambda (Python) Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_flags Feature Flags utility feature-request feature request rejected
Projects
Development

No branches or pull requests

5 participants