-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile should build from alpine instead of scratch #770
Comments
Thanks @xibz - for various reasons we would like to stick with scratch if possible but this seems like an important use case to me. I have filed https://github.com/aws/aws-sdk-go/issues/4193 as it appears to be a gap in the SDK itself, there doesn't seem to be a reason to limit credential_process to environments that have a shell installed. If that got fixed and we updated, would that solve your issue? |
@anuraaga Yep! That works as well! |
@anuraaga may I close this ticket? |
@xibz Unfortunately I don't think we will be changing our base image just for credential_process. From the linked issue you seem to have a (too tedious) workaround for now so are you comfortable closing this in favor of the SDK issue? |
Thanks! Went ahead and closed as the SDK should definitely address this |
Hello! So my team and I are using the
credential_process
feature in the AWS SDK for Go, and this feature allows users to specify their own way of getting credentials through the~/.aws/credentials
file. However, the AWS SDK for Go expectssh
to be present inPATH
. However, scratch does not havesh
. This makes the feature not usable at all with theaws-otel-collector
which is a really odd experience when using AWS credentials files.What I would love to see is either copying
sh
to the scratch workspace or just use alpine all togetherThe text was updated successfully, but these errors were encountered: