Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/cd] Ensure MSI version is incremented before each release #1765

Closed
bryan-aguilar opened this issue Jan 17, 2023 · 3 comments
Closed

[ci/cd] Ensure MSI version is incremented before each release #1765

bryan-aguilar opened this issue Jan 17, 2023 · 3 comments
Assignees
Labels
CI/CD CI/CD related issues/improvements good first issue Good for newcomers

Comments

@bryan-aguilar
Copy link
Contributor

The version in the MSI packaging does not reflect the actual version of the collector. This should match the version of the released collector.

Also, this should be a check that is done during the CD process. The CD should not release assets if this version does not match the value in VERSIONS(minus the v) the preflight step should be added in the CD workflow here.

@bryan-aguilar bryan-aguilar added good first issue Good for newcomers CI/CD CI/CD related issues/improvements labels Jan 17, 2023
@Kausik-A
Copy link
Contributor

Also make sure to introduce delayed start time with reference to the issue here

@bryan-aguilar
Copy link
Contributor Author

Can we track that in a separate issue? That issue does not related to the versioning/install of the collector. It seems more related to a bug in the go toolchain which we may be able to workaround with a delay. I think we should understand if there are other solutions possible also.

@Kausik-A
Copy link
Contributor

Agree, tracking it in #1767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related issues/improvements good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants