Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-react-native] peer support for react-native ^0.76 #5973

Closed
2 tasks
allxie opened this issue Oct 28, 2024 · 8 comments · Fixed by #6266
Closed
2 tasks

[ui-react-native] peer support for react-native ^0.76 #5973

allxie opened this issue Oct 28, 2024 · 8 comments · Fixed by #6266
Labels
feature-request Request a new feature React Native An issue or a feature-request for React Native platform

Comments

@allxie
Copy link

allxie commented Oct 28, 2024

On which framework/platform would you like to see this feature implemented?

React Native

Which UI component is this feature-request for?

Other

Please describe your feature-request in detail.

Currently the peer dependency for react native is described as follows in @aws-amplify/ui-react-native@2.2.16:
"react-native": "^0.70 || ^0.71 || ^0.72 || ^0.73 || ^0.74 || ^0.75",

This results in the following error when upgrading to react native .76:

npm error Found: react-native@0.76.0
npm error node_modules/react-native
npm error   react-native@"0.76.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react-native@"^0.70 || ^0.71 || ^0.72 || ^0.73 || ^0.74 || ^0.75" from @aws-amplify/ui-react-native@2.2.16
npm error node_modules/@aws-amplify/ui-react-native
npm error   @aws-amplify/ui-react-native@"^2.2.16" from the root project

Please describe a solution you'd like.

Would love one of the following:

  • would love support for react-native 0.76, or
  • update to the peer dependency in the package.json if it's already supported, or
  • some updates to documentation about it not being supported yet and why

Thank you!

We love contributors! Is this something you'd be interested in working on?

  • 👋 I may be able to implement this feature request.
  • ⚠️ This feature might incur a breaking change.
@allxie allxie added the feature-request Request a new feature label Oct 28, 2024
@github-actions github-actions bot added pending-triage Issue is pending triage pending-maintainer-response Issue is pending response from an Amplify UI maintainer labels Oct 28, 2024
@jacoblogan
Copy link
Contributor

Thank you for your feature request, we will consider this in our roadmap moving forward.

@jacoblogan jacoblogan added React Native An issue or a feature-request for React Native platform and removed pending-triage Issue is pending triage pending-maintainer-response Issue is pending response from an Amplify UI maintainer labels Oct 29, 2024
@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Nov 8, 2024
@hbuchel hbuchel removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Nov 11, 2024
@brtech99
Copy link

brtech99 commented Dec 12, 2024

This is not a feature request, it's a bug. You can't use amplify UI in react-native in the current version (0.76) without it. in fact, if you try to run the quickstart (https://docs.amplify.aws/react-native/start/quickstart/) it will fail because of this bug. You must have a reason for requiring explicit versions of react-native in this module, but the consequence is that you need to update this dependency whenever react-native bumps a version.

@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Dec 12, 2024
@cwomack
Copy link
Member

cwomack commented Dec 13, 2024

@brtech99 we're keeping this labeled as a feature request for now, but wanted to follow up here and let you know that we've got this internally marked as a high priority item to be resolved in the short term. We'll follow up on this issue as soon as we have a fix out.

@github-actions github-actions bot removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Dec 13, 2024
@mertarica
Copy link

I can't upgrade my packages and can't use new features just because of this bug and I think I'm not alone. Do you guys have any estimation as to when it will be done?

@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Dec 18, 2024
@berg-dee
Copy link
Contributor

berg-dee commented Dec 18, 2024

I'm also stuck at upgrading react native due to this, I've never had this issue before with any library. Why are you even requiring explicit versions of react native?

If you want to ensure compatibility then at least make sure to keep the library up to date and/or communicate this. 0.76 has been out for nearly two months now.

@cwomack
Copy link
Member

cwomack commented Dec 18, 2024

@berg-dee, we appreciate the feedback will update this issue as soon as we can.

@github-actions github-actions bot removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Dec 18, 2024
@giacomoarru
Copy link

I also am affected by this problem

@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Dec 19, 2024
@cwomack
Copy link
Member

cwomack commented Dec 19, 2024

PR #6266 has been introduced to address this issue. Once we have that merged, we'll follow up here.

@github-actions github-actions bot removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature React Native An issue or a feature-request for React Native platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants