Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataStore SyncEngine completely fails when at least one subscription fails. #576

Closed
lawmicha opened this issue Jun 23, 2020 · 5 comments
Closed
Assignees
Labels
bug Something isn't working datastore Issues related to the DataStore category pending-release Code has been merged but pending release Code has been merged but pending release
Milestone

Comments

@lawmicha
Copy link
Contributor

Describe the bug
Using auth directive with different groups such as allow: owner and allow:groups for each model. Sync Engine creates subscriptions for each model. A user that is signed-In may not be enrolled in group. When this happens, the subscription will fail with unauthorized for the model with groups authorization, causing entire sync engine to fail.

To Reproduce
Steps to reproduce the behavior:
#561 (comment)

Expected behavior
A clear and concise description of what you expected to happen.
SyncEngine successfully creates subscriptions for models with owner authorization when the user is signed in, so that data is reconciled with the local store.

@lawmicha lawmicha added bug Something isn't working datastore Issues related to the DataStore category labels Jun 23, 2020
@drochetti drochetti added the pending-triage Issue is pending triage label Jul 8, 2020
@lawmicha lawmicha removed the pending-triage Issue is pending triage label Jul 10, 2020
@lawmicha lawmicha self-assigned this Jul 10, 2020
@lawmicha
Copy link
Contributor Author

subscriptions in sync engine should gracefully fail. Also subscriptions should start failing if permissions are de-escalated (user is removed from a group). this is pending prioitization

@drochetti drochetti added the investigating This issue is being investigated label Jul 10, 2020
@lawmicha lawmicha removed their assignment Oct 13, 2020
@lawmicha
Copy link
Contributor Author

unassigning myself- I believe @diegocstn is working on this

@diegocstn
Copy link
Contributor

@lawmicha yesterday we merged #815, sync engine shouldn't stop anymore if one or more model subscriptions fail

@diegocstn diegocstn self-assigned this Oct 14, 2020
@drochetti drochetti added pending-release Code has been merged but pending release Code has been merged but pending release and removed investigating This issue is being investigated labels Oct 14, 2020
@drochetti
Copy link
Contributor

@lawmicha yesterday we merged #815, sync engine shouldn't stop anymore if one or more model subscriptions fail

Awesome! I labeled as pending release then 🚀

@drochetti drochetti added this to the 1.4.0 milestone Oct 20, 2020
@drochetti
Copy link
Contributor

Amplify 1.4.0 was released and contains the fix to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datastore Issues related to the DataStore category pending-release Code has been merged but pending release Code has been merged but pending release
Projects
None yet
Development

No branches or pull requests

3 participants