Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adjustments to specific id using JSON API seems not work anymore in HyperHDR 20 #953

Closed
ld892012 opened this issue Oct 5, 2024 · 5 comments · Fixed by #956
Closed

Comments

@ld892012
Copy link

ld892012 commented Oct 5, 2024

Bug report, debug log and your config file (FULL LOGS ARE MANDATORY)

LOG

Steps to reproduce

For example, as link :
http://localhost:8090/json-rpc?request=%7B%22command%22:%22adjustment%22,%22adjustment%22:%7B%22id%22:%22Name%22,%22classic_config%22:true,%22luminanceGain%22:1%7D%7D

What is expected?

Change Luminance Gain of id "Name" to "1"

What is actually happening?

It seems to change nothing in this instance

System

HyperHDR Server: 
- Build:           (HEAD detached at v20.0.0.0) (awawa-dev-9e960c9/52f12b4-1711236142)
- Build time:      Mar 23 2024 23:49:20
- Git Remote:      https://github.com/awawa-dev/HyperHDR
- Version:         20.0.0.0
- UI Lang:         auto (BrowserLang: fr)
- Avail Capt:      Linux (V4L2)
- Database:        read/write

HyperHDR Server OS: 
- Distribution:   Armbian 22.08.2 Bullseye
- Architecture:   arm64
- Kernel:         linux (5.15.69-sunxi64 (WS: 64))
- Qt Version:     5.15.2
- Browser:        Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0 

I have tried in v19 without any problems, maybe I just use a depreciated feature

@awawa-dev
Copy link
Owner

Hi
Could you upload the json backup of your configuration?

@ld892012
Copy link
Author

ld892012 commented Oct 5, 2024

Here it is :
HyperHDR-20.0.0.0-Backup-2024-10-05.json

Thanks for your quick response

@ld892012
Copy link
Author

ld892012 commented Oct 7, 2024

I just have tested with a portable install on my PC with one instance of 2 LED and that gives me the same strange behavior, whether I change the id of the first or second LED, it's always the first LED that is modified.

I just set "255,255,255" color and set luminance of id "Second" to 0 then to 1 with this following link :
http://localhost:8090/json-rpc?request={%22command%22:%22adjustment%22,%22adjustment%22:{%22id%22:%22Second%22,%22classic_config%22:true,%22luminanceGain%22:0}}

I give you this new config, logs, system info and LED file (this is more light comparing to my huge config) :
Logs.txt
Config.json
LED_instance.txt

HyperHDR Server: 
- Build:           (HEAD detached at v20.0.0.0) (awawa-dev-9e960c9/52f12b4-1711236142)
- Build time:      Mar 23 2024 23:28:49
- Git Remote:      https://github.com/awawa-dev/HyperHDR
- Version:         20.0.0.0
- UI Lang:         en (BrowserLang: fr)
- Avail Capt:      Windows (Microsoft Media Foundation)
- Database:        read/write

HyperHDR Server OS: 
- Distribution:   Windows 11 Version 22H2
- Architecture:   x86_64
- CPU Model:      11th Gen Intel(R) Core(TM) i5-11400H @ 2.70GHz
- Kernel:         winnt (10.0.22621 (WS: 64))
- Qt Version:     6.5.3
- Browser:        Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0 

Thanks in advance for your help

@awawa-dev
Copy link
Owner

Hi
This functionality was lost when the JSON API (now HyperAPI) was almost completely rewritten on the backend side. Thanks for the report. The fix is ​​available in this PR: #956 (and the setups in the Github Action).

@ld892012
Copy link
Author

ld892012 commented Oct 9, 2024

OK thank you for your work, a fix is now here so i will close this issue

@ld892012 ld892012 closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants