Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.11 breaks compatibility with Scenic gem #3294

Closed
4 of 11 tasks
joshfester opened this issue Oct 1, 2024 · 2 comments · Fixed by #3295
Closed
4 of 11 tasks

v3.11 breaks compatibility with Scenic gem #3294

joshfester opened this issue Oct 1, 2024 · 2 comments · Fixed by #3295
Assignees
Labels
Bug Something isn't working

Comments

@joshfester
Copy link

Describe the bug

I use the Scenic gem to have a couple models that are backed by a materialized view. There have been no issues using Avo up until I try upgrading from v3.10 to 3.11. When I go to the index page for my ProductView model, I get this error:

Expected  `ProductView(product_sku_id: integer, price: decimal, ...)` to be of type: `_Nilable(ActiveRecord::Relation)`

The ProductView model inherits from ActiveRecord::Base like a regular model. I do not get this error for the index page of any other models. I'm not familiar with the Literal gem so not quite sure how to debug.

System configuration

Avo version: 3.10.10

Rails version: 7.1.4

Ruby version: 3.3.5

License type:

  • Community
  • Pro
  • Advanced

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Impact

  • High impact (It makes my app un-usable.)
  • Medium impact (I'm annoyed, but I'll live.)
  • Low impact (It's really a tiny thing that I could live with.)

Urgency

  • High urgency (I can't continue development without it.)
  • Medium urgency (I found a workaround, but I'd love to have it fixed.)
  • Low urgency (It can wait. I just wanted you to know about it.)
@Paul-Bob Paul-Bob moved this to In Review in Issues Oct 2, 2024
@Paul-Bob Paul-Bob self-assigned this Oct 2, 2024
@Paul-Bob Paul-Bob added the Bug Something isn't working label Oct 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Issues Oct 2, 2024
@Paul-Bob
Copy link
Contributor

Paul-Bob commented Oct 2, 2024

Hey @joshfester thanks for reporting this, it should be fixed on Avo 3.13.2

@joshfester
Copy link
Author

Thanks so much @Paul-Bob ! It's working 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants