Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't extend Base.log #9

Closed
ericphanson opened this issue Feb 15, 2022 · 3 comments · Fixed by #12
Closed

Don't extend Base.log #9

ericphanson opened this issue Feb 15, 2022 · 3 comments · Fixed by #12

Comments

@ericphanson
Copy link
Contributor

As the code-comment says, it's bad practice. What's wrong with asking users to write Wandb.log if they want?
@avik-pal
Copy link
Owner

Yeah, I think I will remove the overload, and update the docs to ask people to do Wandb.log

@avik-pal avik-pal mentioned this issue Feb 25, 2022
Merged
@darsnack
Copy link
Contributor

It seems the FluxTraining integration still uses Base.log. Is this intended?

@avik-pal
Copy link
Owner

No just an oversight. Could you send in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates avik-pal/Wandb.jl
3 participants
@darsnack @ericphanson @avik-pal